bootstrap patch

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

bootstrap patch

bkorb
This fixes the "I don't know anything about libtool" error message.
Autoconf needs to be fixed, but meanwhile:

bootstrap: 1.49 1.50 bkorb 17/08/16 10:38:39 (modified, needs delta)

@@ -155,6 +155,12 @@ cp depsver.mf sntp/

 cp bincheck.mf sntp/
 cp depsver.mf sntp/
+export ACLOCAL_PATH=${ACLOCAL_PATH}:
+test -d /usr/local/share/aclocal && \
+    ACLOCAL_PATH=${ACLOCAL_PATH}:/usr/local/share/aclocal:
+test -d /usr/share/aclocal && \
+    ACLOCAL_PATH=${ACLOCAL_PATH}:/usr/share/aclocal:
+ACLOCAL_PATH=${ACLOCAL_PATH%:}

 ${AUTORECONF} -i -v "$@"

Reply | Threaded
Open this post in threaded view
|

Re: [nts] bootstrap patch

Harlan Stenn-2
I haven't looked carefully, but it seems that this will add a few
instances of :: to ACLOCAL_PATH.  Is that OK?

H

On 8/16/2017 10:41 AM, Bruce Korb wrote:

> This fixes the "I don't know anything about libtool" error message.
> Autoconf needs to be fixed, but meanwhile:
>
> bootstrap: 1.49 1.50 bkorb 17/08/16 10:38:39 (modified, needs delta)
>
> @@ -155,6 +155,12 @@ cp depsver.mf sntp/
>
>  cp bincheck.mf sntp/
>  cp depsver.mf sntp/
> +export ACLOCAL_PATH=${ACLOCAL_PATH}:
> +test -d /usr/local/share/aclocal && \
> +    ACLOCAL_PATH=${ACLOCAL_PATH}:/usr/local/share/aclocal:
> +test -d /usr/share/aclocal && \
> +    ACLOCAL_PATH=${ACLOCAL_PATH}:/usr/share/aclocal:
> +ACLOCAL_PATH=${ACLOCAL_PATH%:}
>
>  ${AUTORECONF} -i -v "$@"
>

--
Harlan Stenn, Network Time Foundation
http://nwtime.org - be a Member!

Reply | Threaded
Open this post in threaded view
|

Re: [nts] bootstrap patch

bkorb
It won't hurt. It could (and likely would) slow down the bootstrap by
several milli-seconds. On the other hand, you won't have bootstrap
failures caused by unexpanded LT_LIBTOOL cruft. Fair trade in my book.

Reply | Threaded
Open this post in threaded view
|

Re: [nts] bootstrap patch

Eric Blake-3
On 08/16/2017 03:25 PM, Bruce Korb wrote:
> It won't hurt. It could (and likely would) slow down the bootstrap by
> several milli-seconds. On the other hand, you won't have bootstrap
> failures caused by unexpanded LT_LIBTOOL cruft. Fair trade in my book.

Adding :: to a PATH search is equivalent to adding :.:; having the
current working directory earlier than the end of PATH can sometimes
lead to trojan horses being executed.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


signature.asc (632 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [nts] bootstrap patch

bkorb
Thanks. I fixed that bug. Meanwhile, it seems to me the autotools
ought to be searching installation places for libtool stuff rather
than choking with semi-indecipherable messages.

On Wed, Aug 16, 2017 at 1:39 PM, Eric Blake <[hidden email]> wrote:

> On 08/16/2017 03:25 PM, Bruce Korb wrote:
>> It won't hurt. It could (and likely would) slow down the bootstrap by
>> several milli-seconds. On the other hand, you won't have bootstrap
>> failures caused by unexpanded LT_LIBTOOL cruft. Fair trade in my book.
>
> Adding :: to a PATH search is equivalent to adding :.:; having the
> current working directory earlier than the end of PATH can sometimes
> lead to trojan horses being executed.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
>



--
 - Bruce