[PATCH] autoconf: Create LIBOBJ_DIR in $top_builddir.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] autoconf: Create LIBOBJ_DIR in $top_builddir.

Michael Haubenwallner
* lib/autoconf/general.m4 (AC_CONFIG_LIBOBJ_DIR): Have config.status
create $top_builddir/LIBOBJ_DIR by INIT-CMDS, to support out of source
builds even when nothing else does create $top_builddir/LIBOBJ_DIR.
Based on discussion in https://github.com/westes/flex/issues/244.
---
 lib/autoconf/general.m4 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4
index f783404..4b152df 100644
--- a/lib/autoconf/general.m4
+++ b/lib/autoconf/general.m4
@@ -3014,8 +3014,10 @@ AC_DEFUN([AC_CHECK_DECLS_ONCE],
 # AC_CONFIG_LIBOBJ_DIR(DIRNAME)
 # -----------------------------
 # Announce LIBOBJ replacement files are in $top_srcdir/DIRNAME.
+# Creating $top_builddir/DIRNAME is for out of source builds.
 AC_DEFUN_ONCE([AC_CONFIG_LIBOBJ_DIR],
-[m4_divert_text([DEFAULTS], [ac_config_libobj_dir=$1])])
+[m4_divert_text([DEFAULTS], [ac_config_libobj_dir=$1])dnl
+AC_CONFIG_COMMANDS(,,[\$MKDIR_P "$ac_config_libobj_dir"])])
 
 
 # AC_LIBSOURCE(FILE-NAME)
--
2.10.2


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] autoconf: Create LIBOBJ_DIR in $top_builddir.

Nick Bowler-2
Hello,

On 2017-07-20, Michael Haubenwallner
<[hidden email]> wrote:

> * lib/autoconf/general.m4 (AC_CONFIG_LIBOBJ_DIR): Have config.status
> create $top_builddir/LIBOBJ_DIR by INIT-CMDS, to support out of source
> builds even when nothing else does create $top_builddir/LIBOBJ_DIR.
> Based on discussion in https://github.com/westes/flex/issues/244.
> ---
>  lib/autoconf/general.m4 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4
> index f783404..4b152df 100644
> --- a/lib/autoconf/general.m4
> +++ b/lib/autoconf/general.m4
> @@ -3014,8 +3014,10 @@ AC_DEFUN([AC_CHECK_DECLS_ONCE],
>  # AC_CONFIG_LIBOBJ_DIR(DIRNAME)
>  # -----------------------------
>  # Announce LIBOBJ replacement files are in $top_srcdir/DIRNAME.
> +# Creating $top_builddir/DIRNAME is for out of source builds.
>  AC_DEFUN_ONCE([AC_CONFIG_LIBOBJ_DIR],
> -[m4_divert_text([DEFAULTS], [ac_config_libobj_dir=$1])])
> +[m4_divert_text([DEFAULTS], [ac_config_libobj_dir=$1])dnl
> +AC_CONFIG_COMMANDS(,,[\$MKDIR_P "$ac_config_libobj_dir"])])

This is probably a good idea in principle, but the fix should probably
be done in Automake, since the actual failure is really an Automake
issue.

I suggest that Automake should simply create all the build directories
it normally would regardless of whether or not dependency tracking is
enabled.

Cheers,
  Nick

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] autoconf: Create LIBOBJ_DIR in $top_builddir.

Michael Haubenwallner
Problem forwarded to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27781
/haubi/

On 07/20/2017 03:36 PM, Nick Bowler wrote:

> Hello,
>
> On 2017-07-20, Michael Haubenwallner
> <[hidden email]> wrote:
>> * lib/autoconf/general.m4 (AC_CONFIG_LIBOBJ_DIR): Have config.status
>> create $top_builddir/LIBOBJ_DIR by INIT-CMDS, to support out of source
>> builds even when nothing else does create $top_builddir/LIBOBJ_DIR.
>> Based on discussion in https://github.com/westes/flex/issues/244.
>> ---
>>  lib/autoconf/general.m4 | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4
>> index f783404..4b152df 100644
>> --- a/lib/autoconf/general.m4
>> +++ b/lib/autoconf/general.m4
>> @@ -3014,8 +3014,10 @@ AC_DEFUN([AC_CHECK_DECLS_ONCE],
>>  # AC_CONFIG_LIBOBJ_DIR(DIRNAME)
>>  # -----------------------------
>>  # Announce LIBOBJ replacement files are in $top_srcdir/DIRNAME.
>> +# Creating $top_builddir/DIRNAME is for out of source builds.
>>  AC_DEFUN_ONCE([AC_CONFIG_LIBOBJ_DIR],
>> -[m4_divert_text([DEFAULTS], [ac_config_libobj_dir=$1])])
>> +[m4_divert_text([DEFAULTS], [ac_config_libobj_dir=$1])dnl
>> +AC_CONFIG_COMMANDS(,,[\$MKDIR_P "$ac_config_libobj_dir"])])
>
> This is probably a good idea in principle, but the fix should probably
> be done in Automake, since the actual failure is really an Automake
> issue.
>
> I suggest that Automake should simply create all the build directories
> it normally would regardless of whether or not dependency tracking is
> enabled.
>
> Cheers,
>   Nick
>

Loading...